Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Debug extension] Minor dep updates and cleanup #2507

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[Debug extension] Minor dep updates and cleanup #2507

wants to merge 8 commits into from

Conversation

parlough
Copy link
Member

@parlough parlough commented Oct 4, 2024

Completes some minor cleanup to the debug extension to make migrating to js_interop and package:web a bit easier.

  • Update dependencies to latest
  • Add some missing types to avoid dynamic
  • Use switch expressions and patterns in a few spots where it makes sense
  • Avoid unnecessary non-null assertions in a few places

@parlough parlough requested a review from bkonyi October 7, 2024 19:52
bkonyi
bkonyi approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@bkonyi bkonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one style change. Thanks!

dwds/debug_extension/pubspec.yaml
build_web_compilers: ^4.0.11
built_collection: ^5.1.1
built_value_generator: ^8.9.2
dwds: ^24.1.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes! When was the last time this was published @elliette? Should it be updated?

dwds/debug_extension/web/debug_session.dart Outdated Show resolved Hide resolved
@parlough
Copy link
Member Author

parlough commented Oct 17, 2024 •
edited
Loading

Thanks for taking another look Ben! Please land for me whenever :)

Looks like the failure is an unrelated flake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkonyi bkonyi bkonyi approved these changes

Assignees
No one assigned
Labels
changelog-not-required dart-debug-extension package:dwds
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parlough @bkonyi