deprecated sound/weak sdkSummaryPath for SdkLayout class but kept var…

…iables in constructor to avoid breaking changes
dart-lang · Oct 10, 2024 · 64ba845 · 64ba845
1 parent 5718438
commit 64ba845
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/dwds/CHANGELOG.md b/dwds/CHANGELOG.md
@@ -2,7 +2,7 @@
 
 - Replace deprecated JS code `this.__proto__` with `Object.getPrototypeOf(this)`. - [#2500](https://github.com/dart-lang/webdev/pull/2500)
 - Migrate injected client code to `package:web`. - [#2491](https://github.com/dart-lang/webdev/pull/2491)
-- Deprecated MetadataProvider's, CompilerOptions' & SdkConfiguration's soundNullSafety. - [#2427](https://github.com/dart-lang/webdev/issues/2427)
+- Deprecated MetadataProvider's, CompilerOptions', SdkConfiguration's & SdkLayout's soundNullSafety. - [#2427](https://github.com/dart-lang/webdev/issues/2427)
 
 ## 24.1.0
 

diff --git a/dwds/lib/src/utilities/sdk_configuration.dart b/dwds/lib/src/utilities/sdk_configuration.dart
@@ -45,6 +45,12 @@ class SdkLayout {
   final String summaryPath;
   final String dartdevcSnapshotPath;
 
+  @Deprecated('Only sound null safety is supported as of Dart 3.0')
+  final String soundSummaryPath;
+
+  @Deprecated('Only sound null safety is supported as of Dart 3.0')
+  final String weakSummaryPath;
+
   SdkLayout.createDefault(String sdkDirectory)
       : this(
           sdkDirectory: sdkDirectory,
@@ -65,6 +71,8 @@ class SdkLayout {
   const SdkLayout({
     required this.sdkDirectory,
     required this.summaryPath,
+    this.soundSummaryPath = '',
+    this.weakSummaryPath = '',
     required this.dartdevcSnapshotPath,
   });
 }