Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add health workflow #292

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Add health workflow #292

merged 3 commits into from
Aug 13, 2024

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Aug 13, 2024

Add the PR health workflow and fix a missing license.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Aug 13, 2024
pkgs/unified_analytics/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com>
@mosuem mosuem marked this pull request as ready for review August 13, 2024 15:08
@mosuem mosuem merged commit d563c38 into main Aug 13, 2024
20 of 21 checks passed
@mosuem mosuem deleted the addHealth branch August 13, 2024 15:08
Copy link

github-actions bot commented Aug 13, 2024

PR Health

Breaking changes ✔️

Details
Package Change Current Version New Version Needed Version Looking good?
unified_analytics None 6.1.3-wip 6.1.3-wip 6.1.3-wip ✔️

Changelog Entry ❗

Details
Package Changed Files
package:unified_analytics pkgs/unified_analytics/lib/testing.dart

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Coverage ⚠️

Details
File Coverage
pkgs/unified_analytics/lib/testing.dart 💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ⚠️

Details

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
unified_analytics Condition
PersistedSurvey
GAClient
UserProperty

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️

Details
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Package publish validation ✔️

Details
Package Version Status
package:cli_config 0.2.1-wip WIP (no publish necessary)
package:extension_discovery 2.0.1-wip WIP (no publish necessary)
package:graphs 2.3.2 already published at pub.dev
package:unified_analytics 6.1.3-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@mosuem
Copy link
Member Author

mosuem commented Aug 13, 2024

@andrewkolos the unified_analytics package seems to have some API leaks, see the PR health comment above.

copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 13, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`.

ecosystem (https://github.com/dart-lang/ecosystem/compare/f977423..2719d0c):
  2719d0c  2024-08-08  Devon Carew  add invalid_runtime_check_with_js_interop_types, unintended_html_in_doc_comment (dart-lang/ecosystem#285)

http (https://github.com/dart-lang/http/compare/73fce77..76512c4):
  76512c4  2024-08-07  Kate  test(http_client_conformance_tests): Remove old skips (dart-lang/http#1284)
  d7ae256  2024-08-08  Anikate De  [docs] sort pkg list in ascending order (dart-lang/http#1287)
  b82d88c  2024-08-06  Anikate De  [docs] Add ok_http entry to readme (dart-lang/http#1285)

package_config (https://github.com/dart-lang/package_config/compare/f0b7256..76934c2):
  76934c2  2024-08-06  Kevin Moore  Latest lints, require Dart 3.4 (dart-lang/package_config#157)

sync_http (https://github.com/dart-lang/sync_http/compare/ab8377e..91c0dd5):
  91c0dd5  2024-08-12  dependabot[bot]  Bump actions/checkout from 4.1.6 to 4.1.7 (google/sync_http.dart#49)

test (https://github.com/dart-lang/test/compare/9fbbfdb..8be3c94):
  8be3c948  2024-08-12  Ömer Sinan Ağacan  Run dart2wasm integration test on Windows (dart-lang/test#2265)
  e656e5a9  2024-08-12  Yaroslav Vorobev  fix: use `toFilePath` in package config Uri (dart-lang/test#2262)
  6bfe0d62  2024-08-12  Ömer Sinan Ağacan  Fix documentation rendering issues (dart-lang/test#2264)

tools (https://github.com/dart-lang/tools/compare/55dbd6e..d563c38):
  d563c38  2024-08-13  Moritz  Add health workflow (dart-lang/tools#292)
  8ac5509  2024-08-12  Devon Carew  Update CODEOWNERS for package:unified_analytics (dart-lang/tools#289)

web (https://github.com/dart-lang/web/compare/e89fe49..4996dc2):
  4996dc2  2024-08-12  Srujan Gaddam  Ignore unintended_html_in_doc_comment (dart-lang/web#278)

Change-Id: I808778af5fb9a1f6885ae847614ffb660fcb8662
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/380204
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
@andrewkolos
Copy link
Contributor

@andrewkolos the unified_analytics package seems to have some API leaks, see the PR health comment above.

Thanks for letting me know. Unfortunately, I don't think I'll have time to address this, as I'm preoccupied with P0s/P1s in the flutter CLI tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:unified_analytics skip-changelog-check type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants