Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to current datetime when failing on parse session json file #235

Merged

Conversation

eliasyishak
Copy link
Contributor

Fixes:

This PR changes the error handling behavior when attempting to parse the json file for session data. Instead of trying to parse the newly created file, it will set the current session to the current datetime. This is possibly a race condition issue that will be investigated further in the below issue.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

github-actions bot commented Feb 21, 2024

Package publishing

Package Version Status Publish tag (post-merge)
package:unified_analytics 5.8.3 ready to publish unified_analytics-v5.8.3
package:cli_config 0.1.2 already published at pub.dev
package:extension_discovery 2.0.1-wip WIP (no publish necessary)
package:graphs 2.3.2-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. once this merges, I think you should create a 5.8.0+1 hotfix version to CP to Flutter 3.19

@eliasyishak eliasyishak merged commit c7fbf26 into dart-lang:main Feb 21, 2024
6 checks passed
@eliasyishak eliasyishak deleted the fix-error-handling-for-session branch February 21, 2024 20:33
@eliasyishak eliasyishak restored the fix-error-handling-for-session branch February 21, 2024 20:33
@eliasyishak eliasyishak deleted the fix-error-handling-for-session branch February 21, 2024 20:47
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Feb 27, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`.

http (https://github.com/dart-lang/http/compare/ce0de37..6e0a46f):
  6e0a46f  2024-02-24  Alex Li  [cronet_http] 🏗️ Use dart-define to determine dependency (dart-lang/http#1111)
  d5cab74  2024-02-23  Alex Li  👷 Update configuration related files (dart-lang/http#1091)
  6873731  2024-02-22  Brian Quinlan  Make it possible for `CronetClient` to own the lifetime of an existing `CronetEngine` (dart-lang/http#1137)

protobuf (https://github.com/dart-lang/protobuf/compare/f085bfd..ef0ab7d):
  ef0ab7d  2024-02-23  Sebastian  Optimize repeated field decoding (google/protobuf.dart#911)

tools (https://github.com/dart-lang/tools/compare/9f4e6a4..c7fbf26):
  c7fbf26  2024-02-21  Elias Yishak  Fallback to current datetime when failing on parse session json file (dart-lang/tools#235)

web (https://github.com/dart-lang/web/compare/975e55c..d96c01d):
  d96c01d  2024-02-23  Srujan Gaddam  Use extension types and generics internally (dart-lang/web#184)

yaml_edit (https://github.com/dart-lang/yaml_edit/compare/82ab64d..54884db):
  54884db  2024-02-23  Devon Carew  update to the latest sdk; update lints (dart-lang/yaml_edit#68)

Change-Id: Ib2cb7971df05f4501f81fe5c04b7eaf88d0d93a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/354381
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants