Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrectly sending empty CLIENT_ID when enabling telemetry #143

Closed
eliasyishak opened this issue Aug 9, 2023 · 1 comment
Closed

Incorrectly sending empty CLIENT_ID when enabling telemetry #143

eliasyishak opened this issue Aug 9, 2023 · 1 comment
Assignees
@eliasyishak
Labels
package:unified_analytics

Comments

@eliasyishak
Copy link
Contributor

Currently, when a user runs analytics.setTelemetry(true), we send an event to GA4 saying that the user has opted back in. However, because we clear the CLIENT_ID file when a user opts out, the tool attempts to send an empty string for the CLIENT_ID when opting back in.

We should move the logic to create the client id file before we construct the payload so that the event is being sent with a valid client id.
@eliasyishak eliasyishak self-assigned this Aug 9, 2023
@eliasyishak eliasyishak mentioned this issue Aug 9, 2023
Merged
1 task
@eliasyishak
Copy link
Contributor Author

Closed in:

mosuem pushed a commit that referenced this issue Aug 13, 2024
@dependabot
Bump actions/checkout from 3.3.0 to 3.5.0 (#143)
ee96ba6 
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.3.0 to 3.5.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@ac59398...8f4b7f8)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eliasyishak eliasyishak

Labels
package:unified_analytics
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

143-fix-empty-client-id-string eliasyishak/tools
1 participant
@eliasyishak