Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add containsMatchingInOrder containsEqualInOrder #2284

Merged
merged 5 commits into from
Oct 2, 2024

Commits on Sep 27, 2024

  1. Add containsMatchingInOrder containsEqualInOrder

    The joined behavior in `containsInOrder` has some usability issues:
    - It mimics the arguments for `deepEquals`, but it doesn't have the same
      behavior for collection typed elements. Checking that a nested
      collection is contained in order requires a `Condition` callback that
      uses `.deepEquals` explicitly.
    - The `Object?` signature throws away inference on the `Condition`
      callback arguments. With a method that supports only conditions the
      argument type can be tightened and allow inference.
    natebosch committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    59c354e View commit details
    Browse the repository at this point in the history
  2. Deprecate the old method

    Also deprecate `pairwiseComparesTo`.
    natebosch committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    907d73c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    643884b View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Configuration menu
    Copy the full SHA
    c394c9b View commit details
    Browse the repository at this point in the history
  2. Tweak a sample to make more sense

    The prior version would accept the `0` as meeting the conditions.
    natebosch committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    2a3c854 View commit details
    Browse the repository at this point in the history