Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the IsolateChannel close the ReceivePort #2196

Merged
merged 1 commit into from
Mar 7, 2024

Commits on Mar 6, 2024

  1. Try letting the IsolateChannel close the RecievePort

    The `IsolateChannel` should close the receive port when we call
    `outerChannel.sink.close` which is also added to the `cleanupCallbacks`.
    
    This was originally added in #1280 to try to fix cases where the test
    runner could hang after running some tests specifically on the test
    runner CI when running the test as a subprocess. That PR went through
    changes closing a number of ports speculatively, and this was one likely
    not necessary.
    natebosch committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    c08259d View commit details
    Browse the repository at this point in the history