Introduce a new injection script for new DartPad frontend #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parlough
force-pushed
the
misc/new-inject-script
branch
from
3bddea3 to
a5216c4
Compare
|
Thanks for taking a look John! |
atsansone
pushed a commit
to dart-lang/site-www
that referenced
this pull request
Mar 20, 2024
- Updates to use the new, smaller injection script (introduced in dart-lang/site-shared#205) - Updates the markdown renderer to set the new expected data variables - Removes some old code relating to multi-file DartPad Staged example: https://dart-dev--pr5627-feat-new-dartpad-injection-n1bx8le4.web.app/codelabs/async-await
atsansone
pushed a commit
to atsansone/site-www
that referenced
this pull request
Mar 22, 2024
- Updates to use the new, smaller injection script (introduced in dart-lang/site-shared#205) - Updates the markdown renderer to set the new expected data variables - Removes some old code relating to multi-file DartPad Staged example: https://dart-dev--pr5627-feat-new-dartpad-injection-n1bx8le4.web.app/codelabs/async-await
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This injection script has less functionality and uses a
dataattribute mechanism rather than parsing a singularclassstring, as the combinedclassformat has occasionally been painful to deal with on the static site generation end. Overall this ends up with a much simpler and smaller script (200KB->74KB) :DFixes dart-lang/dart-pad#2793
Fixes dart-lang/dart-pad#2694
Closes dart-lang/dart-pad#1380
Closes dart-lang/dart-pad#1567
I'd like to land this as is with the preview URL, so I can try it out on the downstream sites and prepare them for the new format.
Thanks for taking a look!