Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename container to be more generic #202

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

drewroengoogle
Copy link
Contributor

  • Change the container/image to have a more generic name, as we can use it in other places besides website staging
  • Update the readme to reflect this change
  • Change the directory

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@drewroengoogle drewroengoogle changed the title Rename container Rename container to be more generic Jan 4, 2024
@khanhnwin
Copy link

I don't have approval permissions for this repo. Halp @parlough? Thank you!

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the full context, but looks good to me :)

@drewroengoogle
Copy link
Contributor Author

I don't have the full context, but looks good to me :)

The context is that we realized we are currently building two separate containers that both are used for deploying to firebase, and this one is able to cover both of those cases, meaning we don't have to make updates in two places if we want a new version of firebase-tools. I just wanted to change the naming for clarity

@parlough
Copy link
Member

parlough commented Jan 4, 2024

Less duplication sounds great to me!

Maybe you have already, but you should also check in with Dart EngProd as they might want/need to migrate the Dart specification deployment as well :)

@parlough parlough merged commit a2e3793 into dart-lang:main Jan 4, 2024
6 checks passed
@khanhnwin
Copy link

@parlough Yep! That's on our list. Michael's flagged us down for that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants