debugging issues around specifying the latest patch release

dart-lang · Sep 29, 2023 · 6774c4c · 6774c4c
1 parent 8ef13bc
commit 6774c4c
Show file tree

Hide file tree

Showing 7 changed files with 28 additions and 7 deletions.
diff --git a/.github/workflows/dart.yml b/.github/workflows/dart.yml
@@ -94,7 +94,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        sdk: [2.19, 3.1]
+        sdk: ['2.19', 3.0, '3.1']
       fail-fast: false
     steps:
       - uses: actions/checkout@v3

diff --git a/README.md b/README.md
@@ -91,7 +91,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, macos-latest, windows-latest]
-        sdk: [3.1, stable, beta, dev]
+        sdk: ['3.1', 'stable', 'beta']
     steps:
       - uses: actions/checkout@v3
       - uses: dart-lang/setup-dart@v1

diff --git a/dist/main.cjs b/dist/main.cjs
diff --git a/dist/sig.txt b/dist/sig.txt
diff --git a/lib/main.dart b/lib/main.dart
@@ -24,6 +24,8 @@ void main(List<String> args) async {
       sdk = 'stable';
     }
 
+    print('*** sdk [$sdk] ***');
+
     // flavor
     var flavor = core.getInput('flavor');
     if (flavor.isEmpty) {
@@ -252,6 +254,9 @@ Future<String> findLatestSdkForRelease(String sdkRelease) async {
 }
 
 void _fail(String message) {
+  // 'core.setFailed' throws when we call it; see #107.
+  // core.setFailed(message);
+
+  process.exitCode = 1;
   core.error(message);
-  core.setFailed(message);
 }
diff --git a/lib/node/actions/core.dart b/lib/node/actions/core.dart
@@ -21,8 +21,6 @@ extension type Core (JSObject obj) {
 
   external void exportVariable(String name, String value);
 
-  external void setFailed(String name);
-
   // JSPromise<String>
   external JSPromise getIDToken(String audience);
 }
diff --git a/lib/node/process.dart b/lib/node/process.dart
@@ -18,4 +18,6 @@ extension type Process (JSObject obj) {
 
   /// Read the environment variable [variable].
   String? env(String variable) => getProperty<String?>(_env, variable);
+
+  external set exitCode(int value);
 }