dart fix doesn't trigger on extra_positional_arguments lint

[goderbauer]

For a repro create the following files:

lib/fix_data/foo.yaml

version: 1
transforms:
  - title: 'Remove extra positional'
    date: 2020-11-20
    element:
      uris: ['foo.dart']
      method: 'foo'
      inClass: 'Foo'
    changes:
      - kind: 'removeParameter'
        index: 1

lib/foo.dart

class Foo {
  // This method used to have an extra `String b` parameter, that was removed.
  void foo(int a) {}
}

lib/bar.dart

import 'foo.dart';

void main() {
  // 🔥 This line needs to get fixed to remove the "hello" argument.
  Foo().foo(1, "hello");
}

pubspec.yaml

name: dart_fix_repo
version: 1.2.3

environment:
  sdk: '>=2.12.0 <3.0.0'

Running dart analyze shows that there is an issue:

  error • lib/bar.dart:4:15 • Too many positional arguments: 1 expected, but 2 found. Try removing the extra arguments. • extra_positional_arguments

However, dart fix says there's nothing to fix:

% dart fix --dry-run
Computing fixes in dart_fix_repo (dry run)... 0.5s
Nothing to fix!

The expectation is that this command would have changed the line above marked by 🔥 to be Foo().foo(1);, but it sadly doesn't do that.

[goderbauer]

Pure speculation: I wonder if the problem is that the analyzer issue is on the argument (see screenshot below) and not on the method that the dart fix is targeting in the element clause?

[bwilkerson]

That could well be the problem.

@keertip