Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize browser support in the infrastructure #42417

Closed
6 tasks done
athomas opened this issue Jun 19, 2020 · 1 comment
Closed
6 tasks done

Generalize browser support in the infrastructure #42417

athomas opened this issue Jun 19, 2020 · 1 comment
Assignees
@athomas
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes.

Comments

@athomas
Copy link
Member

athomas commented Jun 19, 2020 •
edited
Loading

@athomas athomas added the area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. label Jun 19, 2020
@athomas athomas self-assigned this Jun 19, 2020
dart-bot pushed a commit that referenced this issue Jun 24, 2020
@athomas
[infra] Add browsers to the DEPS
d8eb844 
The browser used by the test infrastructure are currently pulled in from
the recipes rather than via gclient. This is the first step to remove
that duplicated functionality and will enable all builders to that need
browser to get them.

The browsers aren't downloaded by default and not available on all
platforms. It is not recommend to use these browsers for local testing,
because they may interfere with a user's installation.

#42417

Change-Id: I5df72c3b43f7b49cf90200d47a089714c91b5b3f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152340
Auto-Submit: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
dart-bot pushed a commit that referenced this issue Jun 25, 2020
@athomas
[infra] Download chrome on pkg builders to support web unit tests
06a8b00 
#42417

Change-Id: If678cb418df7b15f98aa2ad49818c908c24089bc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152502
Auto-Submit: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: William Hesse <whesse@google.com>
dart-bot pushed a commit that referenced this issue Jul 7, 2020
@athomas
[test] Add paths to chrome and firefox to the environment when present
40c79c8 
This adds a CHROME_PATH or FIREFOX_PATH environment variable to the
test's evnironment which contains a path to the browser's executable.
This is only set if the --chrome or --firefox argument was passed to
test.py.

#42417

Change-Id: I711de6ab91b8ffbbe72c7fb1530b68c4189a4b8a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153209
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
dart-bot pushed a commit that referenced this issue Jul 8, 2020
@athomas
Revert "[test] Add paths to chrome and firefox to the environment whe…
2b5eaff 
…n present"

This reverts commit 40c79c8.

Reason for revert: Breaks on windows.

Original change's description:
> [test] Add paths to chrome and firefox to the environment when present
> 
> This adds a CHROME_PATH or FIREFOX_PATH environment variable to the
> test's evnironment which contains a path to the browser's executable.
> This is only set if the --chrome or --firefox argument was passed to
> test.py.
> 
> #42417
> 
> Change-Id: I711de6ab91b8ffbbe72c7fb1530b68c4189a4b8a
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153209
> Commit-Queue: Alexander Thomas <athom@google.com>
> Reviewed-by: William Hesse <whesse@google.com>

TBR=whesse@google.com,athom@google.com

Change-Id: I7e1351f9b170ae3ddd218055efb770fe6e1f54e8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153606
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
dart-bot pushed a commit that referenced this issue Jul 10, 2020
@athomas
[infra] Use the gclient provided browsers on all builders
190085d 
This should land after the corresponding recipe change landed:
https://dart-review.googlesource.com/c/recipes/+/153120

#42417

Change-Id: I0eb569e3b0c9c1d401c7924b5e021b259e6638a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153206
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
dart-bot pushed a commit that referenced this issue Jul 10, 2020
@athomas
Reland "[test] Add paths to chrome and firefox to the environment whe…
13fb8c1 
…n present"

This is a reland of 40c79c8

The build recipes now use forward slashes on Windows to pass the path to
the browser executable to test.py.

Original change's description:
> [test] Add paths to chrome and firefox to the environment when present
>
> This adds a CHROME_PATH or FIREFOX_PATH environment variable to the
> test's evnironment which contains a path to the browser's executable.
> This is only set if the --chrome or --firefox argument was passed to
> test.py.
>
> #42417
>
> Change-Id: I711de6ab91b8ffbbe72c7fb1530b68c4189a4b8a
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153209
> Commit-Queue: Alexander Thomas <athom@google.com>
> Reviewed-by: William Hesse <whesse@google.com>

Change-Id: Ib61b8c6424fa7bce525d76d8b94756a215d28c1e
Cq-Include-Trybots: dart/try:dart2js-strong-win-x64-chrome-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153980
Commit-Queue: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Auto-Submit: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
@athomas
Copy link
Member Author

athomas commented Jul 10, 2020

This is completed.

@athomas athomas closed this as completed Jul 10, 2020
@athomas athomas mentioned this issue Jul 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@athomas athomas

Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@athomas