Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DDC excludes some SDK libraries when building the platform in the sdk_nnbd fork #39698

Closed
nshahan opened this issue Dec 6, 2019 · 1 comment
Closed

DDC excludes some SDK libraries when building the platform in the sdk_nnbd fork #39698

nshahan opened this issue Dec 6, 2019 · 1 comment
Assignees
@nshahan
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. NNBD Issues related to NNBD Release web-dev-compiler
Milestone
D29 Release

Comments

@nshahan
Copy link
Contributor

nshahan commented Dec 6, 2019

We are temporarily building a smaller SDK platform to make progress building applications against the forked sdk_nnbd sources. This is because some of the libraries have not yet been ported and they don't compose well.

This is a tracking issue that we can close once all of these excluded libraries have been added back into the SDK that we build applications/tests against.

  • dart:developer
  • dart:io
  • dart:isolate
  • dart:indexed_db
  • dart:html
  • dart:html_common
  • dart:svg
  • dart:web_audio
  • dart:web_gl
  • dart:web_sql
@nshahan nshahan added web-dev-compiler area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. NNBD Issues related to NNBD Release labels Dec 6, 2019
@nshahan nshahan self-assigned this Dec 6, 2019
dart-bot pushed a commit that referenced this issue Dec 9, 2019
@nshahan
[dartdevc] Reduce the number of SDK libraries in the platform
7974f3f 
We are temporarily building a smaller SDK platform to make progress building
applications against the forked sdk_nnbd sources. This is because some of the
libraries have not yet been ported and they don't compose well.

I needed to thread the status of the non-nullable experiment through the front
end entry point and into the target options, and native types.

Also includes some standardization of the flag name in DDC.

#39698

Change-Id: I4bdd503be694b28d7f95828d4af28d1d5fb3691f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127486
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
@vsmenon vsmenon added this to the D28 Release milestone Dec 10, 2019
@sigmundch
Copy link
Member

sigmundch commented Jan 30, 2020 •
edited
Loading

Most are now included at this time (once https://dart-review.googlesource.com/c/sdk/+/133869 lands), only missing dart:io

dart-bot pushed a commit that referenced this issue Jan 30, 2020
@sigmundch
re-add web libraries as part of the sdk
13e3189 
This undoes what we did to get the sdk building earlier. Most tests in lib_2
had runtime failures because native elements were not tagged as such.

Besides re-adding dart:html et al to the list of compiled libraries, this ensures
we handle native/extension types properly.

(See #39698)

Change-Id: Ib8516c6d92d12d0f5dccdb5a6cf66e0990b52aff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133869
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nshahan nshahan

Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. NNBD Issues related to NNBD Release web-dev-compiler
Projects
None yet
Milestone
D29 Release
Development

No branches or pull requests
4 participants
@sigmundch @vsmenon @nshahan @franklinyow