Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private methods/members which are only referenced by a comment are not flagged as unused #37116

Closed
MichaelRFairhurst opened this issue May 29, 2019 · 0 comments
Closed

Private methods/members which are only referenced by a comment are not flagged as unused #37116

MichaelRFairhurst opened this issue May 29, 2019 · 0 comments
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@MichaelRFairhurst
Copy link
Contributor

Repro:

/// [_foo]
int _foo;

Expect: "_foo is not used"
Actual: no errors or warnings.
@MichaelRFairhurst MichaelRFairhurst added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels May 29, 2019
dart-bot pushed a commit that referenced this issue Dec 6, 2019
@srawlins
Ignore _printEvent as an unused element
a455e09 
This is required for #37116

Change-Id: Ia061a423b2455f4e64d5a90f35cc5d7461fa57d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127343
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MichaelRFairhurst