Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart:html IntersectionObserver api requires a call to dart:js allowInterop on dart2js #35484

Closed
jacob314 opened this issue Dec 22, 2018 · 1 comment
Closed

dart:html IntersectionObserver api requires a call to dart:js allowInterop on dart2js #35484

jacob314 opened this issue Dec 22, 2018 · 1 comment
Assignees
@terrylucas
Labels
web-libraries Issues impacting dart:html, etc., libraries

Comments

@jacob314
Copy link
Member

I'm guessing we are just missing a call to convert a Dart function into a JS function in the dart:html code generation.

As expected, IntersectionObserver works under DDC where functions can be passed between Dart and JS without conversion.

Example where I had to add allow interop:
flutter/devtools@13c304c
@jacob314 jacob314 added the web-libraries Issues impacting dart:html, etc., libraries label Dec 22, 2018
@jacob314 jacob314 mentioned this issue Dec 22, 2018
Merged
@terrylucas
Copy link
Contributor

Fix in CL

This was referenced Aug 26, 2019
Closed
Merged
natebosch added a commit to flutter/devtools that referenced this issue Aug 27, 2019
@natebosch
Remove extraneous calls to allowInterop (#966)
846e351 
`allowInterop` is intended for use with `package:js` style callback
arguments to `@JS()` annotated APIs, it is unnecessary when using APIs
from `dart:html`.

This had been put in to work around dart-lang/sdk#35484
which has since been solved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terrylucas terrylucas

Labels
web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jacob314 @terrylucas