Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No devtools console output or input in Dartium #29873

Closed
patkujawa-wf opened this issue Jun 14, 2017 · 7 comments
Closed

No devtools console output or input in Dartium #29873

patkujawa-wf opened this issue Jun 14, 2017 · 7 comments
Assignees

Comments

@patkujawa-wf
Copy link

patkujawa-wf commented Jun 14, 2017

Happened after upgrading to 1.24.0 (via brew). I did a brew switch 1.23.0 and the console for that version was then also not working. I did a full uninstall and reinstall, and still no console.

image

I was launching it via DART_FLAGS='--checked --load_deferred_eagerly' open /Applications/Chromium.app, but same issue when opening via open /Applications/Chromium.app.

@dgrove
Copy link
Contributor

dgrove commented Jun 15, 2017

@terrylucas - can you please take a look?

@daftspaniel
Copy link

Same issue on Linux Ubuntu MATE 17.04.

@terrylucas
Copy link
Contributor

I believe I've narrowed this done to the fact that debuggerModel could come up null in some edge cases causing a fatal error trying to call addEventListener. Only happened in some obscure cases most pages with just JS seem to work.

See CL

@patkujawa-wf
Copy link
Author

Thank you! Will this be incorporated into the dartium that ships with dart 1.24.0, or do we need to wait for the next version?

@terrylucas
Copy link
Contributor

terrylucas commented Jun 20, 2017

It should make it into the next 1.24 stable -- I'll keep you posted. Working on one more fix for WebStorm debugging that needs to make it into 1.24 stable.

terrylucas added a commit that referenced this issue Jun 20, 2017
- Fix DevConsole crash with JS see Issue #29873
     CL https://codereview.chromium.org/2941143002
- Fix debugging in WebStorm, NULL returned for JS objects see Issue #29854
     CL https://codereview.chromium.org/2945063002

TBR=jacobr@google.com

Review-Url: https://codereview.chromium.org/2952643002 .
@jimmyff
Copy link

jimmyff commented Jun 21, 2017

Also having this issue since upgrading to 1.24.0 via brew. 1.24.1 doesn't fix.

screen shot 2017-06-20 at 14 31 23

whesse pushed a commit that referenced this issue Jun 22, 2017
- Fix DevConsole crash with JS see Issue #29873
     CL https://codereview.chromium.org/2941143002
- Fix debugging in WebStorm, NULL returned for JS objects see Issue #29854
     CL https://codereview.chromium.org/2945063002

TBR=jacobr@google.com

Review-Url: https://codereview.chromium.org/2952643002 .
@terrylucas
Copy link
Contributor

Released in 1.24.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants