Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop supporting '@virtual' annotation on fields to allow field overrides in strong mode #28589

Closed
kasperl opened this issue Feb 1, 2017 · 3 comments
Closed

Stop supporting '@virtual' annotation on fields to allow field overrides in strong mode #28589

kasperl opened this issue Feb 1, 2017 · 3 comments
Assignees
@jmesserly
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Milestone
1.24

Comments

@kasperl
Copy link

kasperl commented Feb 1, 2017

Related to #27385 that introduced the support.
@kasperl kasperl added the area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. label Feb 1, 2017
@kasperl kasperl added this to the 1.23 milestone Feb 1, 2017
@mit-mit mit-mit mentioned this issue Feb 1, 2017
Closed
5 tasks
@kasperl
Copy link
Author

kasperl commented Feb 1, 2017

This is blocked on #28120 which in return is blocked on #28119.

@kasperl kasperl added the status-blocked Blocked from making progress by another (referenced) issue label Feb 1, 2017
@bwilkerson bwilkerson added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Feb 1, 2017
@zoechi zoechi mentioned this issue Feb 17, 2017
Closed
@leafpetersen
Copy link
Member

I don't think we need to do anything for this in 1.23, once #28120 happens the code enabling this can be deleted at any point in the future.

@leafpetersen leafpetersen removed this from the 1.23 milestone Feb 27, 2017
@zoechi zoechi mentioned this issue Mar 17, 2017
Closed
@mit-mit mit-mit added this to the 1.24 milestone Mar 21, 2017
@jmesserly jmesserly assigned jmesserly and unassigned leafpetersen Mar 27, 2017
@jmesserly
Copy link

https://codereview.chromium.org/2781443003/

@jmesserly jmesserly removed the status-blocked Blocked from making progress by another (referenced) issue label Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmesserly jmesserly

Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
1.24
Development

No branches or pull requests
5 participants
@jmesserly @kasperl @bwilkerson @leafpetersen @mit-mit