Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive in overridden_fields #499

Closed
alexeieleusis opened this issue Mar 16, 2017 · 2 comments
Closed

False positive in overridden_fields #499

alexeieleusis opened this issue Mar 16, 2017 · 2 comments

Comments

@alexeieleusis
Copy link
Contributor

The rule is not verifying that the base class field has the @virtual annotation which allows the field to be overridden in strong mode.
@zoechi
Copy link

zoechi commented Mar 17, 2017 •
edited
Loading

AFAIK @virtual is deprecated and shouldn't be needed anymore

dart-lang/sdk#28117 (see Cleanup tasks)

See also dart-lang/sdk#28589

@alexeieleusis
Copy link
Contributor Author

Thanks for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zoechi @alexeieleusis