Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run_vm_tests should support running tests through kernel #28264

Closed
mraleph opened this issue Jan 5, 2017 · 4 comments
Closed

run_vm_tests should support running tests through kernel #28264

mraleph opened this issue Jan 5, 2017 · 4 comments
Assignees
@aam
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. front-end-kernel P3 A lower priority bug or feature request

Comments

@mraleph
Copy link
Member

mraleph commented Jan 5, 2017

Our cc tests often load code dynamically.

Right now we are skipping these tests on the Kernel bots but we should instead enable running them through dartk isolate.
@mraleph mraleph added area-kernel area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. labels Jan 5, 2017
@mraleph mraleph mentioned this issue Jan 5, 2017
Open
35 tasks
@mraleph
Copy link
Member Author

mraleph commented Jan 10, 2017

I am working on running all tests through DFE isolate which should enable this.

@mraleph mraleph self-assigned this Jan 10, 2017
@mraleph mraleph removed their assignment Mar 27, 2017
@mraleph
Copy link
Member Author

mraleph commented Mar 27, 2017

We are running co19 language kernel tests through the DFE isolate. However we still can't run vm tests.

This is blocked on #29172

@mraleph mraleph added the status-blocked Blocked from making progress by another (referenced) issue label Mar 27, 2017
@mraleph mraleph mentioned this issue Mar 29, 2017
Closed
15 tasks
aam added a commit that referenced this issue May 15, 2017
@aam
Build up and pass MemoryFileSystem to fasta frontend.
089a355 
Allow kernel service request to provide source files(filename, content), which will be used to build up MemoryFileSystem instance. MemoryFileSystem instance will be used instead of PhysicalFileSystem instance.

Immediate need for this is to support VM unit testing, where small Dart scripts that have to be parsed are hardcoded in the unit tests.

BUG=#28264
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2880453005 .
aam added a commit that referenced this issue May 18, 2017
@aam
Use Kernel frontend from run_vm_tests.
d91f228 
With this change one can run run_vm_tests and pass to it reference to kernel parser snapshot. For example,

out/DebugX64/run_vm_tests --dfe=out/DebugX64/gen/kernel-service.dart.snapshot Debugger_RemoveBreakpoint

As this represents first step, this change enables only tests in debugger_test.cc to run with kernel frontend. There will be follow-up cls that enable all of the VM tests to use kernel frontend.

BUG=#28264
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2881953002 .
aam added a commit that referenced this issue May 22, 2017
@aam
Revert "Revert "Use Kernel frontend from run_vm_tests.""
ddab610 
This reverts commit 530a0df.

This relands https://codereview.chromium.org/2881953002/ that had to be reverted because it caused Dartium build regression. Now fix for Dartium build on mac is in place with Dartium order file update(https://codereview.chromium.org/2887183003) and corresponding Dartium DEPS rollforward(https://codereview.chromium.org/2888283003/).

BUG=#28264
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2898743003 .
aam added a commit that referenced this issue May 23, 2017
@aam
With this change 'tools/test.py -cdartk vm' will run vm tests with Da…
f62a2a9 
…rt Frontend parser.

BUG=#28264
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2881833003 .
aam added a commit that referenced this issue May 25, 2017
@aam
Revert "Revert "With this change 'tools/test.py -cdartk vm' will run …
16c0db1 
…vm tests with Dart Frontend parser.""

This reverts commit e0cdea8.

Update status of vm tests, that don't work with DFE yet.

BUG=#28264
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2895153005 .
aam added a commit that referenced this issue May 25, 2017
@aam
Mark more dartk tests as failing with vm switched to DFE parser
1333f97 
TBR=siva

BUG=#28264

Review-Url: https://codereview.chromium.org/2901103006 .
@a-siva a-siva mentioned this issue May 30, 2017
Closed
aam added a commit that referenced this issue Jun 2, 2017
@aam
Reenable vm tests with -cdartk DFE parser.
6573c74 
This was accidentally disabled in 7e2d9ac.

BUG=#28264
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2920733004 .
@jensjoha
Copy link
Contributor

jensjoha commented Jan 9, 2018

The blocked-on issue is closed.

@jensjoha jensjoha added the P3 A lower priority bug or feature request label Jan 9, 2018
@mraleph
Copy link
Member Author

mraleph commented Apr 24, 2018

@aam I think vm tests are running. Please reopen if this is not the case.

@mraleph mraleph closed this as completed Apr 24, 2018
@mraleph mraleph removed status-blocked Blocked from making progress by another (referenced) issue paramount-17q1 labels Apr 24, 2018
@kmillikin kmillikin added area-front-end Use area-front-end for front end / CFE / kernel format related issues. front-end-kernel labels Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aam aam

Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. front-end-kernel P3 A lower priority bug or feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mraleph @aam @kmillikin @jensjoha