Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement deferred libraries #27343

Closed
jmesserly opened this issue Sep 14, 2016 · 5 comments
Closed

implement deferred libraries #27343

jmesserly opened this issue Sep 14, 2016 · 5 comments
Assignees
@munificent
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dev-compiler

Comments

@jmesserly
Copy link

From @jmesserly on August 31, 2015 16:14

Copied from original issue: dart-archive/dev_compiler#305
@jmesserly
Copy link
Author

@vsmenon just hit this

@jmesserly jmesserly added web-dev-compiler P2 A bug or feature request we're likely to work on labels Sep 14, 2016
@jmesserly jmesserly mentioned this issue Sep 14, 2016
Closed
@vsmenon vsmenon added P1 A high priority bug; for example, a single project is unusable or has many test failures and removed P2 A bug or feature request we're likely to work on labels Oct 6, 2016
@vsmenon
Copy link
Member

vsmenon commented Oct 6, 2016 •
edited by munificent
Loading

@jmesserly - can you help @munificent get started on this? will we need any hooks in the module layer for this?

Note, we can break this into:

Only the first is P1.

@jmesserly
Copy link
Author

If you don't want to make it actually lazy, you shouldn't need anything but supporting the syntax.

@vsmenon
Copy link
Member

vsmenon commented Oct 6, 2016

That sounds like a great step 1. Ideally, we'd enforce the laziness as well. Let me refine the list above.

munificent added a commit that referenced this issue Nov 7, 2016
@munificent
Get the basics of deferred libraries working.
8daf4cf 
References to loadLibrary on a library prefix are compiled to a
helper function that returns a Future that always completes
successfully.

The deferred libraries aren't actually deferred, but code that uses
loadLibrary() now doesn't barf.

BUG=#27343
R=vsm@google.com

Review URL: https://codereview.chromium.org/2477673006 .
@munificent
Copy link
Member

The P1 is done. Filed separate tracking bugs for the other two parts of this, #27776 and #27777.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@munificent munificent

Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dev-compiler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@munificent @jmesserly @vsmenon