Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to handle classes like <cite> that lack their own Element subclasses more cleanly #1990

Closed
jacob314 opened this issue Mar 5, 2012 · 12 comments
Closed

Need to handle classes like <cite> that lack their own Element subclasses more cleanly #1990

jacob314 opened this issue Mar 5, 2012 · 12 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-not-planned Closed as we don't intend to take action on the reported issue library-html P3 A lower priority bug or feature request

Comments

@jacob314
Copy link
Member

jacob314 commented Mar 5, 2012

Need to handle classes like <cite> that lack their own Element subclasses more cleanly
Currently we have to define a hack class called _HTMLElementImpl.
If frog supported
native "*Element,*HTMLElement"
syntax we could clean this up.
@rakudrama
Copy link
Member

I think the current 'hack class' is fine.
You are defining the behaviour of a (hidden native) class with the tag 'HTMLElement' by nominating some superclass and saying the behaviour is the same as that superclass.

I think we will find there are some problems with the proposed 'native "*Element,*HTMLElement"' feature.
For one, the feature demands that we somehow define the methods on two tags, but we don't want the code bloat from duplicating the definitions by 'applying' them to two tags.

I think the 'hack class' is probably the lesser evil.

 

Removed Priority-Medium label.
Added Priority-Low label.

@vsmenon
Copy link
Member

vsmenon commented Apr 13, 2012

Removed Area-UI label.
Added Area-DOM label.

@vsmenon
Copy link
Member

vsmenon commented Jun 22, 2012

Added this to the Later milestone.

@iposva-google
Copy link
Contributor

Removed Area-DOM label.
Added Area-HTML label.

@vsmenon
Copy link
Member

vsmenon commented Aug 17, 2012

Removed the owner.

@blois
Copy link
Contributor

blois commented Feb 27, 2013

Issue #4418 has been merged into this issue.

@DartBot
Copy link

DartBot commented Oct 16, 2013

This comment was originally written by tylerbthrai...@gmail.com

Does this also apply to the <code> tag?

@kevmoo
Copy link
Member

kevmoo commented Apr 7, 2014

Removed Area-HTML label.
Added Area-Library, Library-Html labels.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@alan-knight
Copy link
Contributor

This is clearly not happening soon, and it's not clear if it's even desirable. Let's close and if it re-emerges with more context we can re-examine.

Added WontFix label.

@alan-knight
Copy link
Contributor

Issue #16275 has been merged into this issue.

@jacob314 jacob314 added Type-Defect P3 A lower priority bug or feature request area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-html labels Jan 16, 2015
@kevmoo kevmoo added closed-not-planned Closed as we don't intend to take action on the reported issue and removed resolution-wont_fix labels Mar 1, 2016
copybara-service bot pushed a commit that referenced this issue Feb 27, 2023
@devoncarew
[deps] rev cli_util, crypto, test, vector_math, webdev
cf60e70 
Revisions updated by `dart tools/rev_sdk_deps.dart`.

cli_util (https://github.com/dart-lang/cli_util/compare/fd38b5f..3851652):
  3851652  2023-02-24  Kevin Moore  Move to dart_flutter_team_lints, require Dart 2.19 (#77)
  705bb29  2023-02-24  Kevin Moore  blast_repo fixes (#76)

crypto (https://github.com/dart-lang/crypto/compare/03eb2c9..9efb888):
  9efb888  2023-02-23  Kevin Moore  move to pkg:dart_flutter_team_lints, require Dart 2.19 (#141)

test (https://github.com/dart-lang/test/compare/2cc4144..1307cc5):
  1307cc59  2023-02-23  Nate Bosch  Add ComparableChecks extension (#1960)
  66f2985c  2023-02-24  Pascal Welsch  Fix isNotEmpty rejection (#1959)
  cf10dc5b  2023-02-23  Nate Bosch  Condition must have dynamic generic in deepEquals (#1958)
  6fc48d03  2023-02-23  Nate Bosch  Fix timeouts when a predicate throws instead (#1957)

vector_math (https://github.com/google/vector_math.dart/compare/920e9b6..1e4d000):
  1e4d000  2023-02-23  Kevin Moore  Move to latest team lints, require Dart 2.19 (#281)

webdev (https://github.com/dart-lang/webdev/compare/1e7f9b7..deb801b):
  deb801b  2023-02-24  Devon Carew  contribute issue templates and pull request labeling (#1979)
  74a6520  2023-02-24  Elliott Brooks (she/her)  [MV3 Debug Extension] Use new Dart Debug Extension bug template (#1992)
  c1f325c  2023-02-24  Elliott Brooks (she/her)  [MV3 Debug Extension] Bolt debugging: can reload the page and continue to debug (#1991)
  057f598  2023-02-23  Elliott Brooks (she/her)  [MV3 Debug Extension] Small fixes for building the extension (#1990)
  28a090e  2023-02-23  Anna Gringauze  Run dwds tests in a copy of the sdk directory (#1989)
  b58d3eb  2023-02-23  Anna Gringauze  Run webdev tests in a copy of the sdk directory (#1987)

Change-Id: Iaad67eec68cf3cfeba832abbeb42728043e15b22
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/285760
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-not-planned Closed as we don't intend to take action on the reported issue library-html P3 A lower priority bug or feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@kevmoo @jacob314 @rakudrama @vsmenon @blois @kasperl @alan-knight @iposva-google @DartBot