Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Plus Button Not working on sites with Dart js code #1042

Closed
DartBot opened this issue Jan 4, 2012 · 7 comments
Closed

Google Plus Button Not working on sites with Dart js code #1042

DartBot opened this issue Jan 4, 2012 · 7 comments
Assignees
@efortuna

Comments

@DartBot
Copy link

DartBot commented Jan 4, 2012

This issue was originally filed by pruj...@gmail.com

I think this is more of a Google Plus issue, but it's related to Dart for me, because I'm trying to implement this button on a page with Dart.

I've been able to replicate this with a static gplus button and a dynamically created one.

It looks like the gplus button pulls in a bunch of js globals into it's URL request (see attached file), this creates a situation where the URI is too long and returns an 414 error from plusone.google.com.

Attachment:
uri_too_long.txt (8.17 KB)
@dgrove
Copy link
Contributor

dgrove commented Jan 9, 2012

can you please provide some reproduction instructions?

Added Triaged label.

@DartBot
Copy link
Author

DartBot commented Jan 9, 2012

This comment was originally written by prujo...@gmail.com

Sure there are two ways to repro this:

First Repro Method: Dynamically Created

  1. Go to http://www.lucastudios.com/trylucaui
  2. In the Input box type '<plusone></plusone>'
  3. Click "Refresh Output".

This will generate a plusone button dynamically, which fails inside the iframe with 414 - Requested URL is too large to process. Look at the query string for the plus one iframe and you'll see how it's pulling in a bunch of dart js properties.

Second Repro Method: Static Button

  1. Create a new project in dart editor.
  2. Added the plus one button to the html (this is the default button from the generator page)
    <html>
      <head>
        <title>testing</title>
      </head>
      <body>
        <h1>testing</h1>
        <div id="status">dart is not running</div>
        <g:plusone annotation="inline"></g:plusone>
        <script type="text/javascript" src="testing.dart.app.js"></script>
        <!-- Place this render call where appropriate -->
    <script type="text/javascript">
      (function() {
        var po = document.createElement('script'); po.type = 'text/javascript'; po.async = true;
        po.src = 'https://apis.google.com/js/plusone.js';
        var s = document.getElementsByTagName('script')[0]; s.parentNode.insertBefore(po, s);
      })();
    </script>
      </body>
    </html>

The error this gives is a 400 - Requested URL not found. Again here a bunch of dart properties look to be attached to the iframe query string.

@efortuna
Copy link
Contributor

This JavaScript was generated using frog?

@DartBot
Copy link
Author

DartBot commented Jan 10, 2012

This comment was originally written by prujo...@gmail.com

Yes from the CITY latest builds.

@DartBot
Copy link
Author

DartBot commented Jan 10, 2012

This comment was originally written by pru...@gmail.com

CI builds.

@DartBot
Copy link
Author

DartBot commented Jan 14, 2012

This comment was originally written by prujohn...@gmail.com

+1 is now working as of today's sdk build. :)

@efortuna
Copy link
Contributor

Set owner to @efortuna.
Added Fixed label.

dart-bot pushed a commit that referenced this issue Apr 7, 2021
@athomas
[co19] Roll co19 to 812ab751c41fe8d706fd1e4aae62d2dea2887ac2
4a6a92e 
2021-04-07 irina.arkhipets@gmail.com Fixes #535: more nnbd tests for constant evaluation added.
2021-04-07 sgrekhov@unipro.ru Fixes #1068. Remove excessive - in a SharedOptions
2021-04-05 irina.arkhipets@gmail.com Fixes #535: more nnbd tests for constant evaluation added.
2021-04-05 irina.arkhipets@gmail.com Fixes #996: more tests added.
2021-04-05 irina.arkhipets@gmail.com Fixes #996: more tests added.
2021-04-05 irina.arkhipets@gmail.com Fixes #1067: added checks for old and new dart versions.
2021-04-05 irina.arkhipets@gmail.com Fixes #1066: added @Dart=2.12 to the initial version of the test, new test which checks recent dart behavior added.
2021-04-05 irina.arkhipets@gmail.com Fixes #1057: Expected result doe the tests with mailformed types updated.
2021-04-02 sgrekhov@unipro.ru Fixes #1062. Remove unnecessary assignment
2021-04-01 irina.arkhipets@gmail.com Fixes #1057: Expected result doe the tests with mailformed types updated.
2021-04-01 sgrekhov@unipro.ru Expected error code is fixed for Windows
2021-04-01 sgrekhov@unipro.ru Fixes #1060. Expected error message position updated
2021-04-01 sgrekhov@unipro.ru Fixes #1059. Expected error message updated
2021-04-01 sgrekhov@unipro.ru Fixes #1024. Adjust expected results for web platforms
2021-04-01 sgrekhov@unipro.ru #993. More Array tests added
2021-03-31 58489007+franklinyow@users.noreply.github.com Update LICENSE
2021-03-31 sgrekhov@unipro.ru #993. Array tests added
2021-03-31 irina.arkhipets@gmail.com Issue #1053: Missing Issue tag added, test expectation updated.
2021-03-30 irina.arkhipets@gmail.com Fixes #1054: Updated expectations for mailformed raw type variables.
2021-03-30 irina.arkhipets@gmail.com Fixes #1050: Updated expectations for mailformed raw type variables.
2021-03-30 irina.arkhipets@gmail.com Fixes #1050: Got rid of mailformed row type variable usage in i-2-b- tests.
2021-03-29 sgrekhov@unipro.ru Fixes #1043. Remove static warning as an expected result
2021-03-29 irina.arkhipets@gmail.com Fixes #1049: Correct expectation adjusted
2021-03-29 sgrekhov@unipro.ru Fixes #1048. Move tests to correct folder and change the description
2021-03-29 irina.arkhipets@gmail.com Fixes #1046: Test adjusted to work with the generic metadata feature enabled.
2021-03-29 sgrekhov@unipro.ru Fixes #1047. Change expected result to not to fail on JavaScript configurations
2021-03-29 sgrekhov@unipro.ru Fixes #1044. Change expected result to not to fail on JavaScript configurations
2021-03-26 irina.arkhipets@gmail.com Fixes #1029: Missing Issue tag added to the test.
2021-03-26 sgrekhov@unipro.ru Fixes #1042. Add check that produces different results for triple and double shifts
2021-03-26 sgrekhov@unipro.ru Fixes #1042. Fix built-in_types_t11.dart to expect correct results
2021-03-25 sgrekhov@unipro.ru Fixes #1019. Don't use type aliases in legacy libraries
2021-03-25 irina.arkhipets@gmail.com Fixes #1039: Old-style aliases corrected.
2021-03-25 sgrekhov@unipro.ru Fixes #988. Expect static type warning in a right way
2021-03-24 irina.arkhipets@gmail.com Issues #1029: Static expectation corrected.
2021-03-24 irina.arkhipets@gmail.com Issues #1035: Issue tag for the bug 45443 added.
2021-03-24 irina.arkhipets@gmail.com Merge branch 'master' of https://github.com/dart-lang/co19
2021-03-24 sgrekhov@unipro.ru #1023. Change SplayTreeMap and SplayTreeSet tests according to the new behavior
2021-03-23 sgrekhov@unipro.ru #1021. Remove expecting errors on web configurations for some negative numbers
2021-03-23 sgrekhov@unipro.ru Fixes #1034. Missed experimental flag added
2021-03-23 sgrekhov@unipro.ru #1033. Perform runtime check on big values for non-JavaScript configurations only
2021-03-23 irina.arkhipets@gmail.com Issues #1029: co19/Language/Generics/Superbounded_types/typedef3_A01_t06/02 corrected and does not expect a compile error now.

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: I5fae01c7b48aba502da04638430f4f6de79ac745
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194241
Reviewed-by: William Hesse <whesse@google.com>
copybara-service bot pushed a commit that referenced this issue Nov 6, 2023
@devoncarew
[deps] rev convert, http, native
2e7149b 
Revisions updated by `dart tools/rev_sdk_deps.dart`.

convert (https://github.com/dart-lang/convert/compare/f24afa7..3503170):
  3503170  2023-11-06  Brian Quinlan  Add chunked decoding support to CodePage (#91)

http (https://github.com/dart-lang/http/compare/b9389fe..a2f3c1d):
  a2f3c1d  2023-11-02  Brian Quinlan  Require package:jni >= 0.7.1 to fix macOS build (#1041)
  f953aec  2023-11-02  Brian Quinlan  Fix obsolete `CronetClient()` constructor usage (#1042)
  04777ac  2023-11-02  Brian Quinlan  Add a skeleton "http_profile" package (#1036)

native (https://github.com/dart-lang/native/compare/c72ed16..eaea725):
  eaea725  2023-11-06  Pierrick Bouvier  Preserve temp directory when running isolated test on Windows (#192)

Change-Id: Ic00cccd3a1eb6e38d6381da63524c7a0dac11871
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/334083
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@efortuna efortuna

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dgrove @efortuna @DartBot