Skip to content

Commit

Permalink
Revert "[deps] Update binaryen"
Browse files Browse the repository at this point in the history
This reverts commit a6e8b4e.

Reason for revert: Broke Windows SDK targets, binaryen does not seem 
to build with the C++ compiler used on Windows.

Original change's description:
> [deps] Update binaryen
>
> Update to the latest g3 version.
>
> This version includes WebAssembly/binaryen#6794
> which unblocks https://dart-review.googlesource.com/c/sdk/+/378421.
>
> Change-Id: I9f4e41df9eb9b49d1048e45d4a12f019412e9887
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/379580
> Commit-Queue: Ömer Ağacan <omersa@google.com>
> Reviewed-by: Martin Kustermann <kustermann@google.com>

Change-Id: Icb4d51283cff077e40ca0312e51527480a71c3a5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/379600
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
  • Loading branch information
osa1 authored and Commit Queue committed Aug 8, 2024
1 parent da48538 commit eace2ba
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
2 changes: 1 addition & 1 deletion DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ vars = {
### /third_party/ dependencies

# Prefer to use hashes of binaryen that have been reviewed & rolled into g3.
"binaryen_rev" : "23a1a1aacc0dd14767ca8c53a034b7c6bb4acf52",
"binaryen_rev" : "654ee6e2504f11fb0e982a2cf276bafa750f694b",
"boringssl_gen_rev": "fef055e8d2749b82c79c8f043be1cbe5e8e4b40c",
"boringssl_rev": "2db0eb3f96a5756298dcd7f9319e56a98585bd10",
"browser-compat-data_tag": "ac8cae697014da1ff7124fba33b0b4245cc6cd1b", # v1.0.22
Expand Down
7 changes: 1 addition & 6 deletions third_party/binaryen/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ source_set("binaryen_sources") {
"src/src/tools/fuzzing",
"src/src/wasm",
"src/third_party/llvm-project",
"src/third_party/FP16",
]

# We avoid listing all sources manually, this means when updating
Expand All @@ -104,7 +103,6 @@ source_set("binaryen_sources") {
include_dirs = [
"src/src",
"src/third_party/llvm-project/include",
"src/third_party/FP16/include",
]

# Ensure WasmIntrinsics.cpp/config.h files are generated.
Expand All @@ -130,10 +128,7 @@ template("wasm_tool") {
target_name,
".cpp",
]) ]
include_dirs = [
"src/src",
"src/third_party/FP16/include",
]
include_dirs = [ "src/src" ]
deps = [ ":binaryen_sources" ]
forward_variables_from(invoker, "*")

Expand Down

0 comments on commit eace2ba

Please sign in to comment.