[stable] [vm/aot] Disable graph intrinsics for implicit getters with …

…unboxed record return values

Unboxing of records involves a more complex code, and such intrinsics
would be similar to the normal code of the implicit getters.

TEST=runtime/tests/vm/dart/regress_52449_test.dart

Bug: #52449
Change-Id: Ic6b4ca21609921f0215275be6578f6bbc1fe3eeb
Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/304282
Fixes: #52467
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/304760
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>

CHANGELOG.md

@@ -1,3 +1,8 @@
+## 3.0.3
+
+This is a patch release that:
+- Fixes an AOT compiler crash when generating an implicit getter returning an unboxed record (issue [#52449]).
+
 ## 3.0.2
 
 This is a patch release that:

runtime/tests/vm/dart/regress_52449_test.dart

@@ -0,0 +1,27 @@
+// Copyright (c) 2023, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+// Verifies that compiler doesn't crash when compiling
+// implicit getter with unboxed return value.
+// Regression test for https://github.com/dart-lang/sdk/issues/52449.
+
+abstract class A {
+  (int, int) get foo;
+}
+
+class B implements A {
+  (int, int) get foo => (1, 2);
+}
+
+class C implements A {
+  final (int, int) foo;
+  C(this.foo);
+}
+
+void main() {
+  final list = [B(), C((3, 4))];
+  for (var e in list) {
+    print(e.foo);
+  }
+}

runtime/vm/compiler/intrinsifier.cc

@@ -120,8 +120,9 @@ bool Intrinsifier::CanIntrinsifyFieldAccessor(
       }
     } else {
       // If the field is boxed, then we can either return the box directly or
-      // unbox it and return unboxed representation.
-      return true;
+      // unbox it and return unboxed representation (unless it is a record
+      // which requires a more sophisticated unboxing).
+      return !function.has_unboxed_record_return();
     }
   } else {
     ASSERT(is_setter);