Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only alert about new prereleases for prereleases #2556

Merged
merged 2 commits into from
Jul 10, 2020
Merged

Only alert about new prereleases for prereleases #2556

merged 2 commits into from
Jul 10, 2020

Conversation

sigurdm
Copy link
Contributor

@sigurdm sigurdm commented Jul 9, 2020 •
edited by mit-mit
Loading

Fixes #2555

@sigurdm sigurdm requested a review from jonasfj July 9, 2020 14:15
@sigurdm sigurdm requested a review from mit-mit July 9, 2020 14:15
@jonasfj
Copy link
Member

jonasfj commented Jul 9, 2020

We still have some test failures in: test/global/activate/uncached_package_test.dart

@sigurdm sigurdm merged commit 36c195b into dart-lang:master Jul 10, 2020
sigurdm added a commit that referenced this pull request Jul 10, 2020
@sigurdm
Only alert about new prereleases for prereleases (#2556)
85bdb89
@jonasfj jonasfj mentioned this pull request Jul 10, 2020
Closed
dart-bot pushed a commit to dart-lang/sdk that referenced this pull request Jul 10, 2020
@sigurdm
[pub] Cherry pick fix
66cb8a8 
This contains only the single commit of dart-lang/pub#2556 cherry picked on a branch

Change-Id: I07147955e4bf0e4c5ca077dcaeffd431c991ebb9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153962
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
dart-bot pushed a commit to dart-lang/sdk that referenced this pull request Jul 15, 2020
@sigurdm @whesse
[pub] Cherry pick fix
2c00a13 
This contains only the single commit of dart-lang/pub#2556 cherry picked on a branch

Change-Id: I07147955e4bf0e4c5ca077dcaeffd431c991ebb9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153962
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasfj jonasfj jonasfj approved these changes

@mit-mit mit-mit mit-mit approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't advertize prerelease packages in pub get
4 participants
@sigurdm @jonasfj @mit-mit @googlebot