Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure analysis_options.yaml can only impact DDC builds on the local package #1684

Closed
natebosch opened this issue Aug 10, 2017 · 3 comments · Fixed by #1688
Closed

Make sure analysis_options.yaml can only impact DDC builds on the local package #1684

natebosch opened this issue Aug 10, 2017 · 3 comments · Fixed by #1688
Assignees

Comments

@natebosch
Copy link
Member

We might want to look for analysis_options.yaml in other packages and try to honor those - but at the least the local analysis options should not leak into DDC behavior when compiling other modules.

I think we disallow strongly connected components between packages so it should always be possible to determine the analysis_options.yaml for a module.

This will mean recreating the logic that the analyzer uses since we'll have to pass --options explicitly rather than let it get picked up based on directory structure. cc @bwilkerson

@natebosch
Copy link
Member Author

Some alternatives:

@natebosch
Copy link
Member Author

We might also consider adding a config in the pubspec to let us override which analysis options is passed to DDC.

@jakemac53
Copy link
Contributor

Going to try out passing an empty analysis options file for all dependencies, but not the root package so that will still get whatever settings you have.

This will not support custom analysis options in dependencies but I think that is probably fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants