Tab redesign: removing icon, orange text in dark mode. #8533
Conversation
|
/cc @parlough |
|
Note: available on staging. |
| @@ -19,6 +19,9 @@ d.Node detailTabsNode({ | |||
| children: tabs.map( | |||
| (t) => d.li( | |||
| classes: t.titleClasses, | |||
| attributes: { | |||
| if (t.isPrivate) 'title': 'For authorized users only.', | |||
There was a problem hiding this comment.
I think this is slightly misleading.
I would like the tooltip to reflect the tab title, not the reason for the different color.
There was a problem hiding this comment.
Do you have some examples in mind for that different text?
There was a problem hiding this comment.
I think we should have a title text for each tab:
Something along the lines of:
Readme: "Description of the package"
Changelog: "Describes changes between versions"
Example: "An example of how to use this package"
Installing: "How to use this package in your own project"
Versions: "All published versions of this package"
Scores: "Automated analysis and download metrics"
Admin: "Admin settings for this package - only for admins of this package"
Activity log: "Historical admin and publication events - only for admins of this package"
There was a problem hiding this comment.
Sorry that I was not more clear, but I don't think it should block the landing of this PR. I can live with the titles as they are.
|
I think I'll land this, and add new descriptions as suggested above in a follow-up PR. |
my-<page>links vs/adminnew screens:
--
--
--