Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CSS names and merge colors: neutral background. #8077

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Sep 25, 2024

  • Partial reimplementation of New naming scheme for theme roles + migrating some background colors. #8064, only changing one color role at a time, starting with the neutral (default) background.
  • The neutral role could be thought as synonymous to default, but it is a bit more, e.g. the home screen's cards are also having the same background (over e.g. a grid or a grey background). Also, with the two themes, there is no default background, as the system settings may use the dark mode as default, hence the rename to neutral.
  • The change merges dark mode's #303030 home card background with the neutral (default) background #212121. This is to follow the light theme, where the card has the same background as the default page. #212121 was later switched to darkGunmetal as Flutter website's new dark mode will use that.
  • The new CSS role variable is used as a generic value for setting component's backgrounds, instead of having a separate variable for each component.

@isoos
Copy link
Collaborator Author

isoos commented Sep 27, 2024

Note: applied darkGunmetal color from the Flutter website's upcoming dark mode (it was one of the named colors closest to what they are using).

@isoos isoos merged commit 78c59f7 into dart-lang:master Sep 27, 2024
32 checks passed
@isoos isoos deleted the theme-neutral branch September 27, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants