Make .packages files be more clever about defaults.
#80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `PackageConfig` for a `.packages` file now assigns a default language version of 2.7 to all packages, and if the package location ends in `/lib/`, it assumes the package's root directory is the parent directory of that.
leafpetersen
approved these changes
Mar 13, 2020
| } | ||
| if (packageNames.contains(packageName)) { | ||
| onError(PackageConfigFormatException( | ||
| "Same package name occured more than once", source, start)); | ||
| continue; | ||
| } | ||
| var rootUri = packageLocation; | ||
| if (path.endsWith("/lib/")) { |
There was a problem hiding this comment.
Will this always be relative to something else? That is, can path ever be lib/?
There was a problem hiding this comment.
The "root" package will have a path of lib/.
There was a problem hiding this comment.
The URI reference from the file has already been resolved against the base URI at this point. It can't be lib/ unless the base URI is empty (which it must not be).
jonasfj
approved these changes
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PackageConfigfor a.packagesfile now assigns a default language version of 2.7to all packages, and if the package location ends in
/lib/, it assumes the package'sroot directory is the parent directory of that.