Fix typos. #147
Merged
Fix typos. #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wonders of in-IDE spell checking. Also ask for newest lints (no changes needed).
natebosch
approved these changes
Feb 7, 2024
| /// If [minVersion] is greater than the version read from the | ||
| /// `package_config.json` file, it too is ignored. | ||
| Future<PackageConfig?> findPackagConfigInDirectory(Directory directory, | ||
| Future<PackageConfig?> findPackageConfigInDirectory(Directory directory, |
There was a problem hiding this comment.
[nit] Consider making this private since it is not referenced outside this library.
There was a problem hiding this comment.
Will consider for a later cleanup.
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Apr 11, 2024
…source_map_stack_trace, source_maps Revisions updated by `dart tools/rev_sdk_deps.dart`. args (https://github.com/dart-lang/args/compare/b2e2224..5c83bc9): 5c83bc9 2024-04-11 Devon Carew rev to 2.5.0 and prep to publish (dart-lang/args#267) cli_util (https://github.com/dart-lang/cli_util/compare/12cd216..e222c56): e222c56 2024-04-11 Lasse R.H. Nielsen Make `sdkPath` a getter (dart-lang/cli_util#100) ecosystem (https://github.com/dart-lang/ecosystem/compare/de03da1..95fed18): 95fed18 2024-04-09 Kevin Moore dart_flutter_team_lints: bump pkg:checks dev dep (dart-lang/ecosystem#250) http (https://github.com/dart-lang/http/compare/caad9ca..b7477b1): b7477b1 2024-04-10 Hossein Yousefi Upgrade jni and jnigen to 0.8.0 (dart-lang/http#1176) mockito (https://github.com/dart-lang/mockito/compare/3ef744f..81ecb88): 81ecb88 2024-04-11 Ilya Yanok Fix one README example that were broken by dart-lang/mockito@1dcd822 Also sync the executable version of it with the README. package_config (https://github.com/dart-lang/package_config/compare/486cc4b..854dc19): 854dc19 2024-04-11 Lasse R.H. Nielsen Fix typos. (dart-lang/package_config#147) source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/d03fd9b..9ed8875): 9ed8875 2024-04-10 Kevin Moore Update the latest version of lints (dart-archive/source_map_stack_trace#50) 5f7f3a7 2024-04-09 Kevin Moore blast_repo fixes (dart-archive/source_map_stack_trace#49) source_maps (https://github.com/dart-lang/source_maps/compare/64d07fa..aedfc39): aedfc39 2024-04-09 Kevin Moore blast_repo fixes (dart-lang/source_maps#89) 45a66c3 2024-04-09 Kevin Moore Bump lints, require Dart 3.3 (dart-lang/source_maps#88) Change-Id: Ibe7c030b2b7377ecb5fe81d05ae1df605da1ec6a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/362193 Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Auto-Submit: Devon Carew <devoncarew@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wonders of in-IDE spell checking.
Also ask for newest lints (no changes needed).