Skip to content

Commit

Permalink
Merge pull request #31 from dart-lang/parse_test_fix
Browse files Browse the repository at this point in the history
Invalid test cleanup (parse_test) [TBR].
  • Loading branch information
pq committed Aug 18, 2015
2 parents 6bd62b3 + 022505e commit c0375a8
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 8 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## 0.1.3-dev

- Invalid test cleanup (to keepup with changes in `Uri`).

## 0.1.1

- Syntax updates.
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: package_config
version: 0.1.2
version: 0.1.3-dev
description: Support for working with Package Resolution config files.
author: Dart Team <misc@dartlang.org>
homepage: https://github.com/dart-lang/package_config
Expand Down
7 changes: 0 additions & 7 deletions test/parse_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,6 @@ main() {
equals(base.resolve("../test/").resolve("bar/baz.dart")));
});

test("dot-dot 2", () {
var packages = doParse(singleRelativeSample, base);
expect(packages.packages.toList(), equals(["foo"]));
expect(packages.resolve(Uri.parse("package:qux/../foo/bar/baz.dart")),
equals(base.resolve("../test/").resolve("bar/baz.dart")));
});

test("all valid chars can be used in URI segment", () {
var packages = doParse(allValidCharsSample, base);
expect(packages.packages.toList(), equals([allValidChars]));
Expand Down

4 comments on commit c0375a8

@kevmoo
Copy link
Member

@kevmoo kevmoo commented on c0375a8 Aug 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, could we keep this test, mark it as "skip: 'waiting for fix for SDK XYZ'"

@harryterkelsen
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. The "fix" for this test would mean undoing the fix for dart-lang/sdk#23809. This is testing a behavior we should never have allowed in the first place.

@pq
Copy link
Member Author

@pq pq commented on c0375a8 Aug 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What @hterkelsen said! 👍

@kevmoo
Copy link
Member

@kevmoo kevmoo commented on c0375a8 Aug 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the context. 🤘

Please sign in to comment.