Ensure the NativeAssetsBuildRunner.link() produces a BuildResult with all assets #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… all assets Before this change a bundling tool would * call `buildResult = nativeAssetsBuildRunner.build(...)` * call `linkResult = nativeAssetsBuildRunner.link(buildResult: buildResult, ...) * get all assets via `allAssets = [...buildResult.assets, ...linkResult.assets]` => This PR makes the `link()` command produce a `LinkResult` containing all assets of the final application. => One could view this as the assets from `build()` without a linker to go to a default linker that just emits all of it's inputs. => This allows the `link()` step to also perform the application-wide validation steps (not just over all linker outputs but across build & link outputs) Bundling tools now only have to deal with * `buildResult` in JIT mode (where linking is not enabled) * `linkResult` in AOT mode (where linking is enabled) Instead of dealing with both `buildResult` and `linkResult` in AOT mode.
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
Package publish validation ✔️
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
|
Will update the tests & changelog |
Now that we don't actually run the build step before kernel compilation of the Dart code in any of the embedders (after I made kernel concatenation work for both JIT/AOT), we could actually do that. 👍 |
dcharkes
approved these changes
Oct 7, 2024
Yes, we could make that changes. Though if we ever allowed For now I'll just keep like this to not get too much off-trail (of making the system more flexible). |
|
Thanks, @dcharkes ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change a bundling tool would
buildResult = nativeAssetsBuildRunner.build(...)allAssets = [...buildResult.assets, ...linkResult.assets]=> This PR makes the
link()command produce aLinkResultcontainingall assets of the final application.
=> One could view this as the assets from
build()without a linker to go toa default linker that just emits all of it's inputs.
=> This allows the
link()step to also perform the application-widevalidation steps (not just over all linker outputs but across build &
link outputs)
Bundling tools now only have to deal with
buildResultin JIT mode (where linking is not enabled)linkResultin AOT mode (where linking is enabled)Instead of dealing with both
buildResultandlinkResultin AOT mode.(In some sense one actually would prefer a
NativeAssetsBuilder.buildandNativeAssetsBuilder.buildAndLinkinstead of the current API that exposes theintermediary result from
build(linkingEnabled: true)just to be explicitlypassed on to
linklater on)