@GenerateMocks imports types without taking conditional exports into account

[tolotrasamuel]

With the package image_picker that used conditional import,

@GenerateMocks([
  ImagePicker,
], customMocks: [])
void main() {}

In the generated mock file, it imports this line:

import 'package:image_picker_platform_interface/src/types/picked_file/unsupported.dart'
    as _i27;

And then don't get an error by the static analysis but at compile time, we get this bigger error

lib/tests/mock/mock_lib_generator.outlets.dart:638:48: Error: A value of type 'Future<PickedFile/*1*/?>' can't be returned from an async function with return type 'Future<PickedFile/*2*/?>'.
 - 'Future' is from 'dart:async'.
 - 'PickedFile/*1*/' is from 'package:image_picker_platform_interface/src/types/picked_file/io.dart' ('../../.pub-cache/hosted/pub.dartlang.org/image_picker_platform_interface-2.1.0/lib/src/types/picked_file/io.dart').
 - 'PickedFile/*2*/' is from 'package:image_picker_platform_interface/src/types/picked_file/unsupported.dart' ('../../.pub-cache/hosted/pub.dartlang.org/image_picker_platform_interface-2.1.0/lib/src/types/picked_file/unsupported.dart').
      )).thenAnswer((_) async => getImage.stub.future);
                                               ^
lib/tests/mock/mock_lib_generator.outlets.dart:646:48: Error: A value of type 'Future<PickedFile/*1*/?>' can't be returned from an async function with return type 'Future<PickedFile/*2*/?>'.
 - 'Future' is from 'dart:async'.
 - 'PickedFile/*1*/' is from 'package:image_picker_platform_interface/src/types/picked_file/io.dart' ('../../.pub-cache/hosted/pub.dartlang.org/image_picker_platform_interface-2.1.0/lib/src/types/picked_file/io.dart').
 - 'PickedFile/*2*/' is from 'package:image_picker_platform_interface/src/types/picked_file/unsupported.dart' ('../../.pub-cache/hosted/pub.dartlang.org/image_picker_platform_interface-2.1.0/lib/src/types/picked_file/unsupported.dart').
      )).thenAnswer((_) async => getVideo.stub.future);

Upon check the code, I understood the source of the issue:

picked_file/picked_file.dart

export 'lost_data.dart';
export 'unsupported.dart'
    if (dart.library.html) 'html.dart'
    if (dart.library.io) 'io.dart';

When Mockito build runner lauches, there is no either dart HTML or dart io. So it falls back to the default unsupported implementation. But when you run it on a platform, in my case on web, it a different object.

Expect:

Do not import beyond the condition importation

Stay at picked_file/picked_file.dart

[tolotrasamuel]

Any plan to fix this or a workaround ?

[srawlins]

Hrm de hrm. Good catch. We fixed a similar bug recently so there is an algorithm in place to help with a fix for this bug.