Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CustomMatcher example and test to use cast to Widget. #102

Merged
merged 1 commit into from
Aug 29, 2018
Merged

Update CustomMatcher example and test to use cast to Widget. #102

merged 1 commit into from
Aug 29, 2018

Conversation

kriswuollett
Copy link
Contributor

@kriswuollett
Update CustomMatcher example and test to use cast to Widget.
ab25dc2 
- Encourages the avoidance of dynamic method calls.
@kriswuollett
Copy link
Contributor Author

Ran pub get, pub run test locally.

@kevmoo
Copy link
Member

kevmoo commented Aug 29, 2018

Thanks, @kriswuollett !

@kevmoo kevmoo merged commit afdae58 into dart-lang:master Aug 29, 2018
mosuem pushed a commit to dart-lang/test that referenced this pull request Oct 17, 2024
@kriswuollett @kevmoo
Update CustomMatcher example and test to use cast to Widget. (dart-la…
055c83d 
…ng/matcher#102)

- Encourages the avoidance of dynamic method calls.
- Fixes dart-lang/matcher#101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevmoo kevmoo kevmoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CustomMatcher example should not use dynamic call
3 participants
@kriswuollett @kevmoo @googlebot