This repository has been archived by the owner on Oct 18, 2024. It is now read-only.
Override empty stack traces for traced events #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already default to the current stack trace of the logging caller when there is no stack trace available so the author has some signal for where to look in the code. Also default for non-null but empty stack traces. This is more useful where an empty trace was passed through some signature to satisfy nullability requirements and forwarded to the log.
jakemac53
approved these changes
Mar 7, 2024
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 16, 2024
We already default to the current stack trace of the logging caller when there is no stack trace available so the author has some signal for where to look in the code. Also default for non-null but empty stack traces. This is more useful where an empty trace was passed through some signature to satisfy nullability requirements and forwarded to the log.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already default to the current stack trace of the logging caller when
there is no stack trace available so the author has some signal for
where to look in the code.
Also default for non-null but empty stack traces. This is more useful
where an empty trace was passed through some signature to satisfy
nullability requirements and forwarded to the log.