Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhanced-parts] tests for library_annotations (fix for "part of") #5084

Closed
Tracked by #5024
pq opened this issue Aug 30, 2024 · 1 comment
Closed
Tracked by #5024

[enhanced-parts] tests for library_annotations (fix for "part of") #5084

pq opened this issue Aug 30, 2024 · 1 comment
Assignees
@pq
Labels
new-language-feature P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) type-enhancement A request for a change that isn't a bug type-test

Comments

@pq
Copy link
Member

pq commented Aug 30, 2024 •
edited
Loading

On a little investigation, it looks like library_annotations isn't working correctly for "part of" files, so this will include fixing that.
@pq pq mentioned this issue Aug 30, 2024
Open
@pq pq changed the title [enhanced-parts] evaluate support for library_annotations [enhanced-parts] tests for library_annotations Aug 30, 2024
@pq pq self-assigned this Aug 30, 2024
@pq pq changed the title [enhanced-parts] tests for library_annotations [enhanced-parts] tests for library_annotations (fix for "part of") Aug 30, 2024
@pq pq added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) type-enhancement A request for a change that isn't a bug type-test new-language-feature P1 A high priority bug; for example, a single project is unusable or has many test failures labels Aug 30, 2024
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Aug 30, 2024
@pq
fix library_annotations for “part of” files
a823856 
Fixes: dart-lang/linter#5084

Change-Id: I4192d21ad6dd9fbad889b7e1c4c0a146749c596f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/382905
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
@pq
Copy link
Member Author

pq commented Aug 30, 2024

Fixed w/ dart-lang/sdk@a823856

@pq pq closed this as completed Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
new-language-feature P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) type-enhancement A request for a change that isn't a bug type-test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pq