Fix handling of double tracking for an object. #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polina-c
changed the title
jacob314
approved these changes
Apr 1, 2024
| // Noop if object is already disposed. | ||
| if (_disposalGcCount != null) return; | ||
| if (_disposalGcCount != null) { | ||
| // It is not responsibility of leak tracker to check for double disposal. |
There was a problem hiding this comment.
More of a CL description would help clarify what this CL is doing. Is it handling tracking or just ignoring the double dispose problem? Would expect issue/118 would be closed if the design decision is to not handle the case.
There was a problem hiding this comment.
Thanks. Added comment to the issue: #118 (comment)
There was a problem hiding this comment.
And added description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dispatch of creation and disposal should be idempotent. Leak tracker should not fail or track the same object twice.
Issue #118 suggests more advanced handling.