Enhance scripting. #199
Closed
Enhance scripting. #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type-infra
github-actions
bot
removed
the
type-infra
CoderDake
reviewed
Jan 9, 2024
tool/analyze.sh
Outdated
| @@ -9,28 +9,31 @@ | |||
| # Fast fail the script on failures. | |||
| set -ex | |||
|
|
|||
| sh ./tool/pub_get.sh | |||
| # The directory that this script is located in. | |||
| TOOL_DIR=`dirname "$0"` | |||
There was a problem hiding this comment.
Suggested change
| TOOL_DIR=`dirname "$0"` | |
| TOOL_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd ) |
If you get the full path of the script then you can avoid using cd - below.
The same applies to the other files in this change.
There was a problem hiding this comment.
I got that one liner from: https://stackoverflow.com/a/246128
There was a problem hiding this comment.
I use tool dir to navigate to other directories in order to run flutter commands from project root. How path to the script will help me?
There was a problem hiding this comment.
it will just make it so you don't have to cd - each time. you can just jump directly to the next directory you are working in, i.e.:
cd $TOOL_DIR/../examples/autosnapshotting
flutter analyze --fatal-infos
cd $TOOL_DIR/../examples/leak_tracking
flutter analyze --fatal-infos
cd $TOOL_DIR/../pkgs/leak_tracker
dart analyze --fatal-infos
There was a problem hiding this comment.
since it is the full path, there is no need to use the cd - :)
This reverts commit 0056f30.
github-actions
bot
added
type-infra
Merged
|
Closed in favor of #204 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.