Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing on leak callback #190

Merged
merged 1 commit into from
Dec 10, 2023
Merged

fix: add missing on leak callback #190

merged 1 commit into from
Dec 10, 2023

Conversation

LucasXu0
Copy link
Contributor

@LucasXu0 LucasXu0 commented Dec 8, 2023

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.

The onLeaks callback did not get invoked.

@polina-c
Copy link
Contributor

This code is under refactoring and will be removed.
I will merge it in case you need it to track leaks now.

See the plan here: flutter/flutter#135856

@polina-c polina-c merged commit 9fd7932 into dart-lang:main Dec 10, 2023
3 checks passed
@polina-c
Copy link
Contributor

Feel free to add PR to increase version so that you can take dependency on the fixed leak_tracker.

@LucasXu0
Copy link
Contributor Author

Feel free to add PR to increase version so that you can take dependency on the fixed leak_tracker.

Sure!

This code is under refactoring and will be removed. I will merge it in case you need it to track leaks now.

See the plan here: flutter/flutter#135856

Thanks for the information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polina-c polina-c polina-c approved these changes

@CoderDake CoderDake Awaiting requested review from CoderDake

Assignees
No one assigned
Labels
package:leak_tracker_flutter_testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucasXu0 @polina-c