chore: refactor code style #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polina-c
reviewed
Nov 23, 2023
| @@ -23,8 +23,7 @@ enum LeakType { | |||
| /// Disposed and garbage collected later than expected. | |||
| gcedLate; | |||
|
|
|||
| static LeakType byName(String name) => | |||
| LeakType.values.firstWhere((e) => e.name == name); | |||
| static LeakType byName(String name) => LeakType.values.byName(name); | |||
| } | |||
polina-c
reviewed
Nov 23, 2023
| } | ||
| theContext.addAll(addedContext); | ||
| context ??= {}; | ||
| context!.addAll(addedContext); | ||
| } | ||
|
|
||
| LeakReport toLeakReport() => LeakReport( |
There was a problem hiding this comment.
The intent of the original code to avoid ! and to use null-safety.
The new code has '!' and thus moves null-safety validation from compiler to developer, making it error prone.
Can you revert changes in this files?
There was a problem hiding this comment.
I used the ! syntax because the context must not be null in this case.
How about this change? I will submit it if it's acceptable.
void setContext(String key, Object value) {
context ??= {};
context?[key] = value;
}
void mergeContext(Map<String, dynamic>? addedContext) {
if (addedContext == null) return;
context ??= {};
context?.addAll(addedContext);
}
polina-c
approved these changes
Dec 7, 2023
|
Merged the change. Feel free to create new PR with others. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve the code style and make the code more clear
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.