Update CONCEPTS.md #163
Draft
Update CONCEPTS.md #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
polina-c
reviewed
Nov 2, 2023
| @@ -62,7 +62,7 @@ something is wrong with the tool. | |||
|
|
|||
| ## Culprits and victims | |||
|
|
|||
| If you have a set of not-GCed objects, some of them (victims) | |||
| If you have a set of non-GCed objects, some of them (victims) | |||
There was a problem hiding this comment.
not-GCed is a leak type explained above.
polina-c
reviewed
Nov 2, 2023
| @@ -7,7 +7,7 @@ The text below is under construction. | |||
| This page describes leak tracking concepts. | |||
| See other information on memory leaks [here](../README.md). | |||
|
|
|||
| Before reading about leak tracking, understand [Dart memory concepts](https://docs.flutter.dev/development/tools/devtools/memory#basic-memory-concepts). | |||
| Before reading about leak-tracking, understand [Dart memory concepts](https://docs.flutter.dev/development/tools/devtools/memory#basic-memory-concepts). | |||
There was a problem hiding this comment.
'leak' and 'tracking' are two separate words here.
|
@Chandanmali , do you plan to push this PR forward? Converting it to draft for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed typo and grammer