Skip to content

Commit

Permalink
Fix. typos in leak_tracker
Browse files Browse the repository at this point in the history
  • Loading branch information
droidbg committed Dec 8, 2023
1 parent 1ab3140 commit 991d35b
Show file tree
Hide file tree
Showing 10 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion doc/BASELINE.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ Flutter tests.

## Regression testing

If you want your tests to fail in case of significant diviation from baseline,
If you want your tests to fail in case of significant deviation from baseline,
please, upvote and comment the issue: https://github.com/dart-lang/leak_tracker/issues/120.

## Other than RSS values
Expand Down
2 changes: 1 addition & 1 deletion doc/DETECT.md
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,6 @@ Leak tracking impacts CPU in two areas:
in profile mode on `macos`.

2. Regular asynchronous analysis of the tracked objects.
Took ~2.5 millisectonds for
Took ~2.5 milliseconds for
[Gallery](https://github.com/flutter/gallery) home page in
profile mode on `macos`.
4 changes: 2 additions & 2 deletions doc/TROUBLESHOOT.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Follow the rules to avoid/fix notGCed and notDisposed leaks:

1. **Ownership**. Every disposable object should have clear owner that manages its lifecycle.
2. **Disposal**. The owner should invoke the object's `dispose`.
3. **Release**. The owner should null referernce to the disposed object, if its `dispose` happens earlier than owner's disposal.
3. **Release**. The owner should null reference to the disposed object, if its `dispose` happens earlier than owner's disposal.
4. **Weak referencing**. Non-owners should either link the object with WeakReference, or make sure to
release the references before the owner disposed the object.

Expand Down Expand Up @@ -100,7 +100,7 @@ TODO: link DevTools documentation with explanation
## Verify object references

If you expect an object to be not referenced at some point,
but not sure, you can validate it by temporaryly adding assertion.
but not sure, you can validate it by temporarily adding assertion.

```dart
final ref = WeakReference(myObject);
Expand Down
2 changes: 1 addition & 1 deletion doc/USAGE.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
This page describes how to configure memory usage tracking.
See other information on memory leaks [here](../README.md).

Dart and Flutter applications can be confugured to automatically
Dart and Flutter applications can be configured to automatically
trigger memory usage events and, in case of memory overuse, to save
memory heap snapshots to hard drive.
The snapshots can be later analysed in DevTools.
Expand Down
4 changes: 2 additions & 2 deletions pkgs/leak_tracker/lib/src/leak_tracking/primitives/model.dart
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ class LeakDiagnosticConfig {

/// If true, retaining path will be collected for non-GCed objects.
///
/// The collection of retaining path is a blocking asyncronous call.
/// The collection of retaining path is a blocking asynchronous call.
/// In release mode this flag does not work.
final bool collectRetainingPathForNotGCed;

Expand Down Expand Up @@ -294,7 +294,7 @@ class LeakTrackingConfig {
/// of validation for leaks.
///
/// If the number is too big, the performance may be seriously impacted.
/// If null, the path will be srequested without limit.
/// If null, the path will be requested without limit.
final int? maxRequestsForRetainingPath;
}

Expand Down
2 changes: 1 addition & 1 deletion pkgs/leak_tracker/lib/src/usage_tracking/model.dart
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class MemoryUsageEvent {
}
}

/// Difference with previouse rss value.
/// Difference with previous rss value.
///
/// Equals to `null` for first event.
final int? delta;
Expand Down
2 changes: 1 addition & 1 deletion pkgs/leak_tracker/test/test_infra/data/messages.dart
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ final messages = [
// Requests to app.
RequestForLeakDetails(),

// Successfull responses from app.
// Successful responses from app.
Leaks({}),

// Error responses from app.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ void testWidgetsWithLeakTracking(
LeakTracking.phase = const PhaseSettings.ignored();
}

// Temporarily turn off leak tracking, so that `testWidgests` does not track leaks in addition.
// Temporarily turn off leak tracking, so that `testWidgets` does not track leaks in addition.
final originalGlobalSettings = LeakTesting.settings;
LeakTesting.settings = LeakTesting.settings.withIgnoredAll();

Expand Down
2 changes: 1 addition & 1 deletion pkgs/memory_usage/lib/src/model.dart
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class MemoryUsageEvent {
}
}

/// Difference with previouse rss value.
/// Difference with previous rss value.
///
/// Equals to `null` for first event.
final int? delta;
Expand Down
2 changes: 1 addition & 1 deletion tool/diagrams.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

# Regenerates dependency disgrams for all packages in the repo.
# Regenerates dependency diagrams for all packages in the repo.

# Fast fail the script on failures.
set -ex
Expand Down

0 comments on commit 991d35b

Please sign in to comment.