Enhance the definition of "derives a future type" #3574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrhn
reviewed
Jan 19, 2024
lrhn
approved these changes
Jan 19, 2024
|
Finally got around to this one again. @lrhn, you may wish to take another look because I made some significant changes. |
|
NB: LGTM'd or not, this PR will not land before we've had the next language team meeting. We may need to treat it as a breaking change. |
lrhn
reviewed
Feb 14, 2024
lrhn
approved these changes
Feb 14, 2024
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Feb 28, 2024
Issue #54628 raised the issue that the static analysis of `await e` behaves in unexpected ways when the static type of `e` is a subtype of a future related type, rather than just a plain `Future<T>` or `FutureOr<T>` for some `T`. This CL adds a test that assumes the update to the language specification which is performed by the PR dart-lang/language#3574. Hence, this CL should ONLY BE LANDED if and when that PR is landed. Change-Id: Ib8acb77e24ffbceb0b4034d3b23a0f4fef8e3d1c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/354020 Reviewed-by: Lasse Nielsen <lrn@google.com> Commit-Queue: Erik Ernst <eernst@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See dart-lang/sdk#54628 for some background information.
This PR changes the definition of 'derives a future type' (which is used to define flatten) such that it includes some additional cases (in particular, it will recursively handle
?on types, which was not the case previously).