Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specify conditional imports and introspection #3195

Merged
merged 2 commits into from
Jul 11, 2023
Merged

specify conditional imports and introspection #3195

merged 2 commits into from
Jul 11, 2023

Conversation

jakemac53
Copy link
Contributor

Closes #3036.

@jakemac53 jakemac53 added the static-metaprogramming Issues related to static metaprogramming label Jul 5, 2023
@jakemac53 jakemac53 requested a review from munificent July 5, 2023 20:23
@jakemac53 jakemac53 self-assigned this Jul 5, 2023
munificent
munificent approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@munificent munificent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little hand-wavey, but it's probably the best we can do given how weird conditional imports are.

working/macros/feature-specification.md Outdated Show resolved Hide resolved
@jakemac53 jakemac53 merged commit c125ae1 into main Jul 11, 2023
3 checks passed
@jakemac53 jakemac53 deleted the conditional-imports branch July 11, 2023 14:46
lrhn pushed a commit that referenced this pull request Jul 21, 2023
@jakemac53 @lrhn
specify conditional imports and introspection (#3195)
880e0f7 
Closes #3036.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munificent munificent munificent approved these changes

Assignees

@jakemac53 jakemac53

Labels
static-metaprogramming Issues related to static metaprogramming
Projects
Static Metaprogramming - design/prototype
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conditional imports and macros
2 participants
@jakemac53 @munificent