Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the use-flutter configuration #284

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Remove the use-flutter configuration #284

wants to merge 7 commits into from

Commits on Aug 7, 2024

  1. Remove the use-flutter configuration 

    Always set up the flutter SDK and use `flutter pub publish`, even for
non-flutter Dart packages. The `flutter` command can publish non-flutter
packages so no behavior changes are expected during the publish action.

Directly remove the argument, configuration, and all references
immediately. There is no plan for a deprecation/migration phase since
this only impacts CI, and the fix is trivial.
    @natebosch
    natebosch committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    951dec1 View commit details
    Browse the repository at this point in the history

  2. Remove another use of the argument

    @natebosch
    natebosch committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    f15b1a6 View commit details
    Browse the repository at this point in the history

  3. Bump version and add changelog

    @natebosch
    natebosch committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    dcf6c38 View commit details
    Browse the repository at this point in the history

  4. Remove use-flutter from the health workflow 

    The `dart` command and SDK do come with the `flutter` SDK, so it should
be OK to use the flutter SDK for health checks as well.
    @natebosch
    natebosch committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    f3d637e View commit details
    Browse the repository at this point in the history

  5. Retain the workflow arguments 

    This will allow backwards compatibility for the few files which are
passing it, and can be removed after they are cleaned up.
    @natebosch
    natebosch committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    be67a40 View commit details
    Browse the repository at this point in the history

  6. Restore workflow argument in publish, omit from internal workflow

    @natebosch
    natebosch committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    9d72b6b View commit details
    Browse the repository at this point in the history

  7. Remove another use of --use-flutter

    @natebosch
    natebosch committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    71c9d83 View commit details
    Browse the repository at this point in the history