Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply section styles to divs as well. #3869

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented Sep 4, 2024

The pub.dev infrastructure may rewrite section HTML tags to be div tags, in generated HTML output. While that is going on, we can apply many styles to both section and div tags.

Fixes #3851

See #3851 (comment) for discussion.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

The pub.dev infrastructure may rewrite `section` HTML tags to be `div` tags, in
generated HTML output. While that is going on, we can apply many styles to both
`section` and `div` tags.

See dart-lang#3851 (comment)
for discussion.
@srawlins
Copy link
Member Author

srawlins commented Sep 4, 2024

Ready for review @dart-lang/analyzer-team

@srawlins srawlins merged commit 9ae01ab into dart-lang:main Sep 4, 2024
9 checks passed
@srawlins srawlins deleted the section-is-div branch September 4, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some property pages in the collection package's docs have duplicated content
2 participants