Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privatize several members on PackageGraph #3578

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented Nov 13, 2023

  • Privatize PackageGraph.documentedPackages, PackageGraph.invisibleAnnotations,
  • Remove Package.publicLibraries, just inline into one call site.
  • Remove PackageGraph.sdk, which was only used to initialize sdkLibrarySources, and PackageGraph.allCanonicalModelElements, inlining into the one call site.
  • Initialize sdkLibrarySources in the constructor.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@srawlins srawlins merged commit 68e0749 into dart-lang:main Nov 13, 2023
9 checks passed
@srawlins srawlins deleted the privatize-package-graoh branch November 13, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants