New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ElementType.canHaveParameters; unused #3563

Merged

srawlins merged 1 commit into dart-lang:main from srawlins:can-have-parameters

Oct 31, 2023

Member

srawlins commented Oct 31, 2023

I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.
Most changes should add an entry to the changelog and may need to rev the pubspec package version.
Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.


          Remove ElementType.canHaveParameters; unused

srawlins requested a review from kallentu

October 31, 2023 21:10

kallentu approved these changes

View reviewed changes

Member

kallentu left a comment

This looks good, but dang, we just have things that are completely unused?
What was this used for before anyways?...

srawlins merged commit ab845cb into dart-lang:main

9 checks passed

srawlins deleted the can-have-parameters branch

October 31, 2023 22:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet