Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten types and visibilities #3559

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

srawlins
Copy link
Member

A variety of cleanups:

  • InheritingContainer: hasPublicInheritedMethods, inheritedFields, publicInheritedFields, publicInheritedMethods are only visible for testing (should probably be tightened beyond that).
  • _cacheNewModelElement's newModelElement parameter is non-nullable.
  • _constructFromPropertyAccessor's two named parameters are required.
  • On the allConstructedModelElements map, the library part of the key is non-nullable, as is the value.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@srawlins srawlins merged commit 17c5e5a into dart-lang:main Oct 30, 2023
9 checks passed
@srawlins srawlins deleted the tighten-types branch October 30, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants