Use a sun-like icon for light theme toggle instead of moon #3309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srawlins
approved these changes
Jan 24, 2023
|
As a drive-by-comment, @parlough, I see you've been making a lot of contributions recently to dartdoc - much appreciated :) Would you mind updating the changelog w/ the changes you've made since our last publish (1f42216, on or around Dec. 13th). It would just need to be the changes that we think are user-facing. We should also bump the pubspec to a newer version - |
|
Sure! - #3315 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the docs use the same moon icon for toggling back to light mode. This PR adjusts that to switch to a sun-like icon when in dark mode:
New:
Before:
